From 9028a15613b1276028f4b2e9e175d488e1ef4df9 Mon Sep 17 00:00:00 2001 From: Akira Sudoh Date: Thu, 1 Feb 2018 01:48:23 +0900 Subject: [PATCH] fix(DataTable): remove hard-coded ID for (#559) Also made a change to `` to make `id` prop fully optional. Fixes #552. --- src/components/DataTable/DataTable-story.js | 1 + src/components/DataTable/DataTable.js | 1 - src/components/Search/Search.js | 6 +++++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/components/DataTable/DataTable-story.js b/src/components/DataTable/DataTable-story.js index 9e32b8dfbcaa..bc022e59dc9e 100644 --- a/src/components/DataTable/DataTable-story.js +++ b/src/components/DataTable/DataTable-story.js @@ -230,6 +230,7 @@ class BasicDataTable extends Component { diff --git a/src/components/DataTable/DataTable.js b/src/components/DataTable/DataTable.js index 38c46ef1d053..6b89b7e6f75b 100644 --- a/src/components/DataTable/DataTable.js +++ b/src/components/DataTable/DataTable.js @@ -346,7 +346,6 @@ export const DataTableSearch = props => { className={className} {...other} small - id="search-2" labelText="Filter table" placeHolderText="Search" onChange={onChange} diff --git a/src/components/Search/Search.js b/src/components/Search/Search.js index 84b1dd202649..2f9a1b66df77 100644 --- a/src/components/Search/Search.js +++ b/src/components/Search/Search.js @@ -117,7 +117,11 @@ export default class Search extends Component { const { className, type, - id, + id = (this._inputId = + this._inputId || + `search__input__id_${Math.random() + .toString(36) + .substr(2)}`), placeHolderText, labelText, small,