Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies version error #502

Closed
q962 opened this issue Jul 16, 2024 · 3 comments
Closed

devDependencies version error #502

q962 opened this issue Jul 16, 2024 · 3 comments
Labels
r-worksforme Can't reproduce the issue and it's unlikely to occur again

Comments

@q962
Copy link

q962 commented Jul 16, 2024

Two packages involved:

  • prettier
$ ./node_modules/.bin/prettier --ignore-path .gitignore --check .
Checking formatting...
src\components\oops-notification.vue[error] src\components\oops-notification.vue: SyntaxError: Unexpected closing tag "script". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (156:1)
[error] 154 | clearErrorLog();
[error] 155 | });
[error] > 156 | </script>
[error] | ^^^^^^^^^^
[error] 157 |
[error] 158 | <style module>
[error] 159 | .msg {
All matched files use Prettier code style!

$ ./node_modules/.bin/prettier --version
2.8.8

Solution, upgrade to the latest version

Although I develop on Windows, I think the package that gives the error doesn't differentiate between systems.

So I'm wondering. Why does everything work fine in your environment?

@josh-berry
Copy link
Owner

Honestly? No idea. I recommend building in WSL if you're on Windows; nothing in the build system is set up to support native Windows.

❯ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

❯ git rev-list -1 HEAD
ebf6855be23b42035583ebe0aa330a6c493ef4ab

❯ ./node_modules/.bin/prettier --version
2.8.8

❯ ./node_modules/.bin/prettier --ignore-path .gitignore --check .
Checking formatting...
All matched files use Prettier code style!

@josh-berry
Copy link
Owner

I have updated all of Tab Stash's dependencies (which I do periodically anyway) so you might want to give this another try. Again, though, I recommend building in WSL using the Makefile rather than trying to do things by hand. The build is (unfortunately) quite finicky thanks to the number of "frameworky" dependencies Tab Stash relies on (sigh).

@q962
Copy link
Author

q962 commented Jul 21, 2024

OK.

I use msys2 on Windows, which provides a similar experience.

Unless the project itself depends on native functionality, there are basically no problems.

Regarding the error with prettier, I can't find the same, only similar. And it seems to only happen on Windows.

@q962 q962 closed this as completed Jul 21, 2024
@josh-berry josh-berry added the r-worksforme Can't reproduce the issue and it's unlikely to occur again label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r-worksforme Can't reproduce the issue and it's unlikely to occur again
Projects
None yet
Development

No branches or pull requests

2 participants