Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search in text mode when read only #251

Closed
crystalrain125 opened this issue Apr 5, 2023 · 3 comments
Closed

Implement search in text mode when read only #251

crystalrain125 opened this issue Apr 5, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@crystalrain125
Copy link

crystalrain125 commented Apr 5, 2023

Could we provide search functionality to text mode when in read-only mode? It's currently supported in tree mode.

Screenshot 2023-04-05 at 4 49 18 PM

@josdejong
Copy link
Owner

Good idea, thanks for your suggestion!

Anyone interested in implementing support for search (not replace) in text mode when read only?

@josdejong josdejong added enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2023
@josdejong josdejong changed the title Feature-request: read only mode search Feature-request: search in text mode when read only Apr 6, 2023
@josdejong josdejong changed the title Feature-request: search in text mode when read only Implement search in text mode when read only Apr 6, 2023
@laneparton
Copy link

@josdejong This is something I'm interested in for our application. I was experimenting a little bit with the repo - this is my first time actually looking at the underlying package, codemirror.

I'm sure you've got plenty of experience with codemirror 😄, do you think we could achieve this with the editable + readOnly options?

I see the comments from this PR: #130

Maybe we need to specifically handle mobile, but open up editable as an option? What are your thoughts or how would you advise moving forward?

@josdejong
Copy link
Owner

Thanks for your offer Lane.

I looked into it, and it was mainly caused by #142. I fixed #142 now and made sure the search button is displayed in readOnly mode (50f8889).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants