Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test failures make development difficult #77

Closed
pbregener opened this issue Oct 1, 2018 · 1 comment · Fixed by #76
Closed

Intermittent test failures make development difficult #77

pbregener opened this issue Oct 1, 2018 · 1 comment · Fixed by #76
Labels
bug User-facing bugs

Comments

@pbregener
Copy link
Contributor

Adding features to gitlint (or improving existing ones) is unfortunately pretty difficult due to intermittently failing integration tests. This can also be seen in simple pull requests such as #73.

I tried a few things in #76, but haven't been able to fix it so far.

My feeling is that it is related to unicode string handling, possibly also in connection with an outdated version of sh that returns the strings that are compared to the reference result. The sh changelog shows quite a few unicode-related bugs being fixed in versions newer than the one currently used by gitlint. Those newer versions appear to be incompatible with gitlint today, so simply updating the dependency is not enough.

@jorisroovers
Copy link
Owner

jorisroovers commented Oct 3, 2018

Thanks for your ongoing interest and contributions to gitlint :-)

This is a problem I've been experiencing for a long time and also haven't been able to definitely figure out what's going on. I agree that it's probably related to unicode handling.

Will keep this open for ongoing tracking.

edit:
Btw, I personally only rarely experience this problem when running tests on my local machine or on a VM. Yet for some reason these seem to occur on every Travis run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug User-facing bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants