Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where should I get all the tabs data? #4

Closed
alexaung opened this issue Nov 22, 2021 · 4 comments
Closed

Where should I get all the tabs data? #4

alexaung opened this issue Nov 22, 2021 · 4 comments

Comments

@alexaung
Copy link

Where should I get all the tabs data? I am using flutter_chord and when user click the chord I want to show the tabs. May I know where can I get all the tabs data?

@joranmulderij
Copy link
Owner

They don't get provided by the package, but here are some links to projects that do provide them. They might not perfectly align with the api of this package, but making them fit should not be too difficult.
I will do an update to support some more diverse input types. I will also add these links to the readme.

Hope this helps you!

@alexaung
Copy link
Author

@joranmulderij Thank you so much for json chords and wonderful plugin.

@jeremiahlukus
Copy link

jeremiahlukus commented Jun 30, 2022

@joranmulderij hey would you be opposed to including this data in the package? Then remove the required tab param and add a tuning param.

FlutterGuitarTab(
  tuning: 'EADGBE'
  name: 'Dm'
  tabName: 'Dm',  // || tab: []
)

so you would have to include either tab or tabName

I was planning on forking and making this change just seeing if you are open to PR's for this.

@joranmulderij
Copy link
Owner

The reason I'm not doing this is because it would increase the size of the package. Some users might want to dynamically download the tabs. Forcing data into a package is not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants