Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to replacing failure with thiserror? #27

Closed
jssblck opened this issue Apr 12, 2022 · 5 comments · Fixed by #28
Closed

Open to replacing failure with thiserror? #27

jssblck opened this issue Apr 12, 2022 · 5 comments · Fixed by #28

Comments

@jssblck
Copy link
Contributor

jssblck commented Apr 12, 2022

Hey there! I'm starting a new project using this library.

Now that failure is deprecated, and the ecosystem is moving towards a system where libraries report implementations of Error, would you be open to a PR replacing usage of failure with proper Error implementations?

@jonhoo
Copy link
Owner

jonhoo commented Apr 13, 2022

Absolutely!

@jssblck
Copy link
Contributor Author

jssblck commented Apr 19, 2022

@jonhoo awesome, thanks! I put in a PR here: #28

@jssblck
Copy link
Contributor Author

jssblck commented Apr 19, 2022

@jonhoo also, I was looking over the other issues and saw this:

I'm also looking for maintainers if anyone using Faktory on a regular basis is looking to step up to the plate

My company is building out at least one large-ish rust system that uses faktory for job dispatch (and we already use faktory heavily in other languages), so I will likely be trying to upstream multiple PRs as part of that over the coming weeks/months/longer (depending on what issues we run into).

I'm open to stepping up to the plate here- happy to talk more about what that'd look like and how I can help!

@jonhoo
Copy link
Owner

jonhoo commented Apr 24, 2022

@kitified That'd be amazing! I've added you as a maintainer of the GitHub project. I'll hold off on the crates.io release privileges for the time being, but as you ramp up on the project I'm happy to share that too :) Even though you have permissions now, please do keep submitting PRs and I'll do my best to give reviews in a timely fashion!

@jssblck
Copy link
Contributor Author

jssblck commented Apr 24, 2022

Sounds great, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants