Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for compatibility with current PHPUnit versions #617

Closed
iansltx opened this issue Feb 3, 2019 · 2 comments
Closed

Update tests for compatibility with current PHPUnit versions #617

iansltx opened this issue Feb 3, 2019 · 2 comments

Comments

@iansltx
Copy link
Contributor

iansltx commented Feb 3, 2019

Will need to look at backward/forward compatibility here. The tests work with 5.x but they're using the old non-namespaced syntax. PHPUnit 5.x is the latest PHP 5.6 compatible version of PHPUnit so this upgrade may be a multi-step process depending on functionality deprecated/removed since PHPUnit 5.
@iansltx
Copy link
Contributor Author

iansltx commented Feb 3, 2019

This might already be handled, assuming no deprecations for PHPUnit 6/7: #445

@ericpoe ericpoe mentioned this issue May 4, 2019
Merged
@heiglandreas
Copy link
Member

This is fixed with #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heiglandreas @iansltx