Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 10.11 support? #73

Closed
1 task done
kengruven opened this issue Feb 23, 2018 · 1 comment
Closed
1 task done

macOS 10.11 support? #73

kengruven opened this issue Feb 23, 2018 · 1 comment

Comments

@kengruven
Copy link
Collaborator

Please help prevent duplicate issues before submitting a new one:

  • I've searched other open/closed issues for duplicates before opening up this new issue.

Report

What did you do?

  • I built Down.framework for macOS, using Carthage.
  • Then I dragged the framework to my Mac application (which is built for 10.11).

What did you expect to happen?

The application would (still) build.

What happened instead?

Xcode refused to build the application, because Down.framework has MACOSX_DEPLOYMENT_TARGET = 10.12.

Down doesn't use any 10.12 APIs, though, so there doesn't appear to be any downside to changing it to MACOSX_DEPLOYMENT_TARGET = 10.11.

An older macOS target isn't out of line with the other supported platforms. Down.framework still claims to support iOS 8, for example, which is roughly the age of macOS 10.10.

@iwasrobbed
Copy link
Collaborator

Happy to accept a pull request for this and other tickets (I don't personally use Down with macOS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants