Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for complex numbers #14

Open
AlexanderKoshkarov opened this issue Nov 15, 2016 · 4 comments
Open

Support for complex numbers #14

AlexanderKoshkarov opened this issue Nov 15, 2016 · 4 comments

Comments

@AlexanderKoshkarov
Copy link

It would be nice if the package would support the complex numbers. Probably it is difficult to check when the derivative exist, and what path to take on the complex plane to take derivative. However if you will make default derivative path (for example along real axis) it should be good enough (I think) for DifferentialEquations.jl by @ChrisRackauckas where derivatives are used to calculate Jacobian in implicit ODE integrators.
If it would be possible to indicate the curve on complex plane where to take derivative, it also would be awesome. Thanks.

@ChrisRackauckas
Copy link

It seems that Complex64 doesn't have eps defined which interferes with step_size. If that was somehow avoided, would the routines theoretically work correctly? Or is there a difficulty I'm not seeing?

I think always taking the derivative along the real axis is fine because if the function is complex differentiable then it's path independent.

@johnmyleswhite
Copy link
Owner

Sorry, I was unclear in the other repository. I do not accept feature requests. If you are interested in writing code that provides this functionality, I will review a pull request.

You should find all the information you need to implement such a pull request here: http://deeplearning.net/software/theano/proposals/complex_gradient.html

@AlexanderKoshkarov
Copy link
Author

Sorry for the confusion. Thanks for the link.

@ChrisRackauckas
Copy link

The final solution on this was to create DiffEqDiffTools.jl which handles this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants