Merge pull request #17 from sharathmalladi/users/sharathm/rename_mode…

…l_get Use similar method names for export and import apis
johnhuang01 · Feb 18, 2022 · 3f648fa · 3f648fa
2 parents b9fcb6f + 98a8ab6
commit 3f648fa
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 6 deletions.
diff --git a/sdk/personalizer/Azure.AI.Personalizer/src/Models/PersonalizerAdministrationClient.cs b/sdk/personalizer/Azure.AI.Personalizer/src/Models/PersonalizerAdministrationClient.cs
@@ -306,10 +306,24 @@ public virtual Response<Stream> GetPersonalizerModel(bool isSigned = false, Canc
             }
         }
 
+        /// <summary> Export the current model used by Personalizer service. </summary>
+        /// <param name="cancellationToken"> The cancellation token to use. </param>
+        /// <remarks> Gets the signed Personalizer model. </remarks>
+        public virtual async Task<Response<Stream>> ExportPersonalizerSignedModelAsync(CancellationToken cancellationToken = default)
+        {
+            return await GetPersonalizerModelAsync(true, cancellationToken).ConfigureAwait(false);
+        }
+
+        /// <summary> Export the current model used by Personalizer service. </summary>
+        public virtual Response<Stream> ExportPersonalizerSignedModel(CancellationToken cancellationToken = default)
+        {
+            return GetPersonalizerModel(isSigned: true, cancellationToken);
+        }
+
         /// <summary> Replace the current model used by Personalizer service with an updated model. </summary>
         /// <param name="modelStream">Stream representing the digitally signed model zip archive.</param>
         /// <param name="cancellationToken"> The cancellation token to use. </param>
-        public virtual async Task<Response> ImportPersonalizerModelAsync(Stream modelStream, CancellationToken cancellationToken = default)
+        public virtual async Task<Response> ImportPersonalizerSignedModelAsync(Stream modelStream, CancellationToken cancellationToken = default)
         {
             using var scope = _clientDiagnostics.CreateScope("PersonalizerAdministrationClient.ImportPersonalizerModel");
             scope.Start();
@@ -327,7 +341,7 @@ public virtual async Task<Response> ImportPersonalizerModelAsync(Stream modelStr
         /// <summary> Replace the current model used by Personalizer service with an updated model. </summary>
         /// <param name="modelStream">Stream representing the digitally signed model zip archive.</param>
         /// <param name="cancellationToken"> The cancellation token to use. </param>
-        public virtual Response ImportPersonalizerModel(Stream modelStream, CancellationToken cancellationToken = default)
+        public virtual Response ImportPersonalizerSignedModel(Stream modelStream, CancellationToken cancellationToken = default)
         {
             using var scope = _clientDiagnostics.CreateScope("PersonalizerAdministrationClient.ImportPersonalizerModel");
             scope.Start();

diff --git a/sdk/personalizer/Azure.AI.Personalizer/tests/Personalizer/ModelTests.cs b/sdk/personalizer/Azure.AI.Personalizer/tests/Personalizer/ModelTests.cs
@@ -18,20 +18,34 @@ public async Task ModelTest()
         {
             PersonalizerAdministrationClient client = GetAdministrationClient(isSingleSlot: true);
             await GetModel(false, client);
+            await GetModel(true, client);
             await GetModelProperties(client);
-            Response<Stream> response = await GetModel(true, client);
-            await ImportModel(response.Value, client);
+            Response<Stream> response = await ExportSignedModel(client);
+            await ImportSignedModel(response.Value, client);
             await ResetModel(client);
         }
 
+        [Test]
+        public async Task ExportImportModelTest()
+        {
+            PersonalizerAdministrationClient client = GetAdministrationClient(isSingleSlot: true);
+            Response<Stream> response = await ExportSignedModel(client);
+            await ImportSignedModel(response.Value, client);
+        }
+
         private async Task<Response<Stream>> GetModel(bool signed, PersonalizerAdministrationClient client)
         {
             return await client.GetPersonalizerModelAsync(signed);
         }
 
-        private async Task<Response> ImportModel(Stream modelStream, PersonalizerAdministrationClient client)
+        private async Task<Response<Stream>> ExportSignedModel(PersonalizerAdministrationClient client)
+        {
+            return await client.ExportPersonalizerSignedModelAsync();
+        }
+
+        private async Task<Response> ImportSignedModel(Stream modelStream, PersonalizerAdministrationClient client)
         {
-            return await client.ImportPersonalizerModelAsync(modelStream);
+            return await client.ImportPersonalizerSignedModelAsync(modelStream);
         }
 
         private async Task ResetModel(PersonalizerAdministrationClient client)