Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark awaitNodeBySelector() as @ExperimentalTime #81

Closed
joffrey-bion opened this issue May 11, 2021 · 0 comments
Closed

Mark awaitNodeBySelector() as @ExperimentalTime #81

joffrey-bion opened this issue May 11, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented May 11, 2021 •
edited
Loading

Kotlin 1.5 brings a breaking change with the Duration class, and this affects the generation of mangled names for all methods using Duration as argument (for instance, the coroutines' delay(Duration) method).

Since awaitNodeBySelector uses Duration as argument, it is not correct to just @OptIn and we should instead mark the API as experimental too.

We should also provide a stable alternative so that people don't have trouble migrating (see #82)
@joffrey-bion joffrey-bion added the enhancement New feature or request label May 11, 2021
@joffrey-bion joffrey-bion mentioned this issue May 11, 2021
Closed
@joffrey-bion joffrey-bion changed the title Mark awaitNodeBySelector() as @ExperimentalTime to warn before Kotlin 1.5 migration Mark awaitNodeBySelector() as @ExperimentalTime May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion