From f420583c741b3ff5fa3f0fc919f1906f56268e8c Mon Sep 17 00:00:00 2001 From: Alexander Makarenko Date: Sat, 30 Apr 2016 18:55:46 +0200 Subject: [PATCH] doc: make `writable.setDefaultEncoding()` return `this` Let this function return `this` for parity with `readable.setEncoding()`. PR-URL: https://github.com/nodejs/node/pull/5040 Fixes: https://github.com/nodejs/node/issues/5013 Reviewed-By: Matteo Collina Reviewed-By: Calvin Metcalf Reviewed-By: James M Snell --- doc/api/stream.md | 1 + lib/_stream_writable.js | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/api/stream.md b/doc/api/stream.md index 83fb13d71e55c7..a7478bf3deed3d 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -695,6 +695,7 @@ file.end('world!'); #### writable.setDefaultEncoding(encoding) * `encoding` {String} The new default encoding +* Return: `this` Sets the default encoding for a writable stream. diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index daef34b50c4fc5..76c4972d405c81 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -251,6 +251,7 @@ Writable.prototype.setDefaultEncoding = function setDefaultEncoding(encoding) { if (!Buffer.isEncoding(encoding)) throw new TypeError('Unknown encoding: ' + encoding); this._writableState.defaultEncoding = encoding; + return this; }; function decodeChunk(state, chunk, encoding) {