Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom YouTube-overlay only working for first video of an entry #767

Closed
scharmach opened this issue Jan 23, 2025 · 2 comments
Closed

Custom YouTube-overlay only working for first video of an entry #767

scharmach opened this issue Jan 23, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@scharmach
Copy link

Steps to Reproduce

  1. Open a feed entry that has at least two YouTube-videos
  2. Only the first YouTube-video of the entry has the custom overlay

This leads to the same problems that I've described here: #465 (comment)

Thanks for the general implementation, and I hope it can be changed so that the overlay is displayed for every video.

Expected behavior

The overlay should be put on top of every YouTube-video an entry has.

Screenshots or screen recording

Image

Device, Operating system, and app version

No response

@scharmach scharmach added the bug Something isn't working label Jan 23, 2025
@jocmp
Copy link
Owner

jocmp commented Jan 23, 2025

Thanks @scharmach. I was able to reproduce this with my test feed (https://jocmp.com/capy/index.xml). I'll take a look at the bug and keep you posted here when I have a fix.

@jocmp
Copy link
Owner

jocmp commented Jan 24, 2025

This fix is available as of 2025.01.1098-dev. Please let me know if you run into it again, and thanks for all your help with this feature!

@jocmp jocmp closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants