From 6b9e4fb5dbe33f1f37bee9f72fabeea1b8bd3452 Mon Sep 17 00:00:00 2001 From: Saswata Mukherjee Date: Tue, 28 May 2024 14:19:33 +0100 Subject: [PATCH] Cut patch release `v0.35.1` (#7394) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * compact: recover from panics (#7318) For https://github.com/thanos-io/thanos/issues/6775, it would be useful to know the exact block IDs to aid debugging. Signed-off-by: Giedrius Statkevičius * Sidecar: wait for prometheus on startup (#7323) Signed-off-by: Michael Hoffmann * Receive: fix serverAsClient.Series goroutines leak (#6948) * fix serverAsClient goroutines leak Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * fix lint Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * update changelog Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * delete invalid comment Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove temp dev test Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * remove timer channel drain Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --------- Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> * Receive: fix stats (#7373) If we account stats for remote write and local writes we will count them twice since the remote write will be counted locally again by the remote receiver instance. Signed-off-by: Michael Hoffmann * *: Ensure objstore flag values are masked & disable debug/pprof/cmdline (#7382) * *: Ensure objstore flag values are masked & disable debug/pprof/cmdline Signed-off-by: Saswata Mukherjee * small fix Signed-off-by: Saswata Mukherjee --------- Signed-off-by: Saswata Mukherjee * Query: dont pass query hints to avoid triggering pushdown (#7392) If we have a new querier it will create query hints even without the pushdown feature being present anymore. Old sidecars will then trigger query pushdown which leads to broken max,min,max_over_time and min_over_time. Signed-off-by: Michael Hoffmann * Cut patch release v0.35.1 Signed-off-by: Saswata Mukherjee --------- Signed-off-by: Giedrius Statkevičius Signed-off-by: Michael Hoffmann Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> Signed-off-by: Saswata Mukherjee Co-authored-by: Giedrius Statkevičius Co-authored-by: Michael Hoffmann Co-authored-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com> --- CHANGELOG.md | 17 +++++++++++++++++ pkg/receive/handler.go | 8 ++++---- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 51f2a8e06a..2caadc320a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,23 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re ### Removed +## [v0.35.1](https://github.com/thanos-io/thanos/tree/release-0.35) - 28.05.2024 + +### Fixed + +- [#7323](https://github.com/thanos-io/thanos/pull/7323) Sidecar: wait for prometheus on startup +- [#6948](https://github.com/thanos-io/thanos/pull/6948) Receive: fix goroutines leak during series requests to thanos store api. +- [#7382](https://github.com/thanos-io/thanos/pull/7382) *: Ensure objstore flag values are masked & disable debug/pprof/cmdline +- [#7392](https://github.com/thanos-io/thanos/pull/7392) Query: fix broken min, max for pre 0.34.1 sidecars +- [#7373](https://github.com/thanos-io/thanos/pull/7373) Receive: Fix stats for remote write +- [#7318](https://github.com/thanos-io/thanos/pull/7318) Compactor: Recover from panic to log block ID + +### Added + +### Changed + +### Removed + ## [v0.35.0](https://github.com/thanos-io/thanos/tree/release-0.35) - 02.05.2024 ### Fixed diff --git a/pkg/receive/handler.go b/pkg/receive/handler.go index c3d14bbb68..ea7ca9e055 100644 --- a/pkg/receive/handler.go +++ b/pkg/receive/handler.go @@ -714,10 +714,10 @@ type remoteWriteParams struct { func (h *Handler) gatherWriteStats(writes ...map[endpointReplica]map[string]trackedSeries) tenantRequestStats { var stats tenantRequestStats = make(tenantRequestStats) - for _, write := range writes { - for er := range write { - for tenant, series := range write[er] { - samples := 0 + for write := range writes { + for er := range write { + for tenant, series := range write[er] { + samples := 0 for _, ts := range series.timeSeries { samples += len(ts.Samples)