Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example doesn't work #1

Closed
manask88 opened this issue May 9, 2016 · 5 comments
Closed

Example doesn't work #1

manask88 opened this issue May 9, 2016 · 5 comments
Assignees

Comments

@manask88
Copy link

manask88 commented May 9, 2016

I think you forgot to include some files in your push. RN complains that It cannot find the app/routes folder. I took a quick look and I couldn't even find the app folder for the example!

@jmurzy
Copy link
Owner

jmurzy commented May 10, 2016

Thanks for the heads up. I've just open sourced the core early this morning. I'm still working on documentation and an example app. It might take a couple daysweeks, but I'll try to get one up soon.

🍺

@jonathanglasmeyer
Copy link
Collaborator

I am looking for a routing lib that provides a react-router API and your approach is the only one I've found. I'd be interested in helping out. A running example would be a great start. 👍🏻:)

@jmurzy
Copy link
Owner

jmurzy commented May 23, 2016

@jonathanewerner I'd love some help here for sure 👍— however, the reason I've not been able to publish an example is that the NavigationExperimental API is going through a drastic clean up phase that forces me to make breaking changes.

Believe me I'm putting in all the extra hours I can to publish this to npm—but perhaps you're right and I should just put an example up and see how the community can help with some of this.

🍺

@jmurzy jmurzy self-assigned this May 24, 2016
@jonathanglasmeyer
Copy link
Collaborator

jonathanglasmeyer commented May 24, 2016

Ok, good to know the background here. I'm just getting started with the react-native ecosystem, so this helps to know what you're dealing with.
Your gif-example looks quite comprehensive. Would it make sense to have a "minimal" example to get something working first? Maybe that one won't break as much? Just a thought.
At work we have an react webapp that we want to also implement in react native (main reason: ios push notifications). We hope to be able to share the container components between web and native. These components depend on react-router and a flux implementation. If we want to go down that route it means that we need to find a react-router compatible routing lib. So i've pretty much got a full-time job's worth of time to put in to this lib if it proves viable.
If you can provide pointers at where help is needed, i'll be happy to jump in. 👍 :)

@jmurzy jmurzy closed this as completed in e6ab000 May 27, 2016
@jmurzy
Copy link
Owner

jmurzy commented May 27, 2016

I just added an example app to the repo—but keep in mind that everything is still experimental.

Also, I'm still working on the default behavior of <StackRoute>, especially when they are nested. So we are not quite there yet, and I think, to prevent distractions we should not publish this to npm as is.

@jonathanewerner if you are still interested in helping, going forward, I'll be documenting my progress in Github Issues. I greatly appreciate contributions and feel free to ping me on Discord when if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants