Fix npm#6270: Do not log warnings about log cleanup when logs_max=0

Jeff Mealo · Jeff Mealo · commit 950ab3f27b2f · 2023-03-17T11:23:11.000-04:00
diff --git a/lib/utils/log-file.js b/lib/utils/log-file.js
@@ -223,7 +223,10 @@ class LogFiles {
         }
       }
     } catch (e) {
-      log.warn('logfile', 'error cleaning log files', e)
+      // If the user has disabled writing to logs, they're not expecting warnings about log cleanup failures
+      if (this.#logsMax > 0) {
+        log.warn('logfile', 'error cleaning log files', e)
+      }
     } finally {
       log.silly('logfile', 'done cleaning log files')
     }

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,10 @@ class LogFiles {`
`223`	`223`	`}`
`224`	`224`	`}`
`225`	`225`	`} catch (e) {`
`226`		`- log.warn('logfile', 'error cleaning log files', e)`
	`226`	`+ // If the user has disabled writing to logs, they're not expecting warnings about log cleanup failures`
	`227`	`+ if (this.#logsMax > 0) {`
	`228`	`+ log.warn('logfile', 'error cleaning log files', e)`
	`229`	`+ }`
`227`	`230`	`} finally {`
`228`	`231`	`log.silly('logfile', 'done cleaning log files')`
`229`	`232`	`}`