-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] support C++11 #2
Comments
I think But if possible, C++11 support would be nice and I would very much appreciate it if you can work on that. BTW, please be aware that this library is not yet production-ready and API will be overhauled, and also I cannot work on it for a while because the fall quarter has begun and I have to turn my mindset back into my major. Thanks! |
At 1st glance this implementation is not using newer C++ features: https://github.com/abolz/Drachennest/blob/master/src/dragonbox.cc I am not sure it they perform the same in terms of speed and memory use though. |
Alexander's implementation is not very different from mine I believe. But what @biojppm is interested in is probably string-to-float conversion rather than float-to-string conversion as far as I understand, so possibly Dragonbox is pretty irrelevant to him. |
I am less interested in what version of the language is used as long as:
Even if C++20 is used if the meta programming stuff can be cut down or simplified this would be most welcome. |
Thanks for your thorough work!
Would you consider accepting a MR for supporting C++11?
if constexpr
is really handy, but since it is not allowed in C++11, I could rewrite with SFINAE. But the code would be uglier and less readable as a result.If that would be too much for you, maybe having a permanent
cpp11
branch would do?The text was updated successfully, but these errors were encountered: