Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to change Push To Talk/PTT shortcut #3464

Open
BloodyIron opened this issue Sep 19, 2018 · 28 comments
Open

[Feature Request] Ability to change Push To Talk/PTT shortcut #3464

BloodyIron opened this issue Sep 19, 2018 · 28 comments
Labels
confirmed Confirmed bug, should not go stale feature-request Issue which suggest an idea, enhancement or feature to implement

Comments

@BloodyIron
Copy link

Hi Folks,

My understanding is that Riot.im uses jitsi for voice stuff, and they've pointed me to here for my request ( element-hq/element-web#5993 )

Now, Ctrl + T is the push to talk key as it is now, however, that doesn't work for everyone.

Any chance we could get the functionality to change the PTT/Push To Talk key combination? And perhaps in a way that Riot.im can nicely call too?

With many people using Jitsi for voice comms, being able to change the keyboard shortcut is a common expectation in VoIP applications. It's literally in every other popular VoIP implementation out there. So, it'd be swell if we could get it in Jitsi too.

Please? :)

@anoadragon453
Copy link

Fwiw pretty sure 'Space' is the default push-to-talk key, not Ctrl+T, but yes +1 for being able to change it!

@saghul
Copy link
Member

saghul commented Oct 17, 2018

Indeed it’s space.

As for the feature request, our current implementation of keyboard shortcuts is not really clean so making it configurable is not easy at the moment.

I personally like the idea though!

@anoadragon453
Copy link

I'm looking into potentially adding this as a feature to Riot and making it configurable from there. Would still be nice to see it in native Jitsi though :)

If keyboard shortcuts can be configured on the fly then it should be too bad, right? Otherwise yeah, might be kind of hard.

@BloodyIron
Copy link
Author

I know for sure that anyone wanting to use riot (which uses jitsi for VoIP) will want to be able to set their own push to talk key binding. So, that seems like something that should be in jitsi first perhaps?

@anoadragon453
Copy link

Sure, although I think it would be cool if we could make push-to-talk work even when Riot is minimized, which will require a little work on our side as well.

@saghul
Copy link
Member

saghul commented Oct 17, 2018

AFAIK Riot uses the iframe API, which can mute / unmute with API calls. So I'd say having Riot handle this makes sense to me.

@BloodyIron
Copy link
Author

Riot having PTT while minimised is also something I think that people won't want to compromise on! :D So many other VoIP apps already do that (Mumble/Teamspeak/Ventrilo/Discord/Skype/etc).

@anoadragon453
Copy link

I am working on it!

@skylord123
Copy link

This would be awesome. This is one of the features I am dying to have (especially working while minimized).

@stale
Copy link

stale bot commented Jan 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@anoadragon453
Copy link

This is still a useful feature for Jitsi imo. Will post an update from the Riot side on element-hq/element-web#5993 in a moment.

@stale stale bot added the wontfix Issue won't be fixed label Jan 18, 2019
@stale stale bot closed this as completed Jan 25, 2019
@anoadragon453
Copy link

Aww, stalebot :(

@stale stale bot removed the wontfix Issue won't be fixed label Jan 25, 2019
@aaronkvanmeerten
Copy link
Member

Stablebot gets overzealous sometimes.

@BloodyIron
Copy link
Author

IMO we need to beat stale bot up in a 4-way Quake FFA. Teach 'em a lesson!

@Mikaela
Copy link

Mikaela commented Jan 27, 2019

A bit offtopic, but are the shortcut keys such as space for PTT documented anywhere? I was coming here to request it.

@damencho
Copy link
Member

Just type '?' in a meeting.

@stale
Copy link

stale bot commented Apr 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Apr 27, 2019
@BloodyIron
Copy link
Author

But we neeeeeeeeeeeeeed it! D:

@stale stale bot removed the wontfix Issue won't be fixed label Apr 28, 2019
@Mikaela
Copy link

Mikaela commented Apr 29, 2019

The previous time I was in need of PTT, one of my issues was chat box opening by itself or me forgetting it open and it ate the space so I sometimes spoke without anyone hearing me.

I think customizability would be the best option and I would use right Ctrl which I am used to using with Mumble and Discord as it doesn't overlap with anything else and shouldn't be eaten as long as I had Jitsi Meet focused.

@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jul 28, 2019
@Mikaela
Copy link

Mikaela commented Jul 28, 2019

Has this been fixed? This is currently my biggest problem with Jitsi Meet, especially if I drop links or something else into the chat.

@stale stale bot removed the wontfix Issue won't be fixed label Jul 28, 2019
@Mikaela

This comment has been minimized.

@saghul saghul added the confirmed Confirmed bug, should not go stale label Jul 29, 2019
@sr-verde
Copy link

Is there any progress at this issue? It would be so nice in the current situation.

@saghul
Copy link
Member

saghul commented Mar 19, 2020

No, and it’s unlikely to happen specially now that we are all hands on deck keeping the service working for everyone.

@sr-verde
Copy link

Pity! Nevertheless, good work and wish you success!

@BloodyIron
Copy link
Author

:/

@Echolon Echolon added the feature-request Issue which suggest an idea, enhancement or feature to implement label May 22, 2020
@mcd1992
Copy link

mcd1992 commented Mar 23, 2021

👍 bump before stalebot creeps in

@ghost
Copy link

ghost commented Nov 11, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug, should not go stale feature-request Issue which suggest an idea, enhancement or feature to implement
Projects
None yet
Development

No branches or pull requests

10 participants