Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions are deleted when the connection status changes quickly back to disconnected #172

Open
mareksuscak opened this issue Feb 18, 2025 · 2 comments

Comments

@mareksuscak
Copy link

mareksuscak commented Feb 18, 2025

Hey there. Following up on the other issue I reported recently, I finally managed to get some additional logs:

Image

I really do not know how to reproduce this issue, but I think this is key to figuring it out. It appears that when the client successfully reconnects here and then goes on to restore subscriptions here the connection may drop again before all subscriptions are re-established when the network isn't stable (or the process is under huge pressure) and that code isn't handling a connection loss event properly which trigger the removal that I don't think is correct behavior. Generally a very specific class of errors should trigger removal of all subscriptions and when the client isn't connected, this should juts eject out of that code and retry the whole reconnection again. Thoughts?

In case it helps, here's our configuration of AdsClient:

connectionCheckInterval: ms('1s'),
timeoutDelay: ms('5s'),
connectionDownDelay: 0,
autoReconnect: true,
reconnectInterval: ms('1s'),
@mareksuscak
Copy link
Author

Hi @jisotalo. Did you have a chance to look at this issue?

@jisotalo
Copy link
Owner

Unfortunately I haven't had time for this. If you could create a some way I could reproduce this, it would help a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants