Rebased the v3.0.0 branch on master #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfan-dahir
requested changes
Jun 4, 2022
- explicit throw if no URL can be found for reviews - usage of array_filter for the "each" method call on dom search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #411
I took the changes from the 3.0.0 branch and rebased them on master, because it seems that a single revert commit prevented the correct fast forward merge on 25th of May. Please review @irfan-dahir
This also includes fixes for minor issues:
The linting and the tests are failing with this, I couldn't fix the errors, so I skipped the git hooks.
I tried to test it out in an interactive shell, most of the manga/anime stuff works, I haven't tested all, I will do more testing when I have time again.