Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix userupdates status parsing #344

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

N0D4N
Copy link
Contributor

@N0D4N N0D4N commented Apr 11, 2021

List entries, with any status except Plan to Watch/Read, when list entry has zero progress (0 watched episodes/0 read chapters) and entry doesn't have total episodes/chapters, in most cases it means that entry is ongoing, MAL displays like Status - e.g. Watching - instead of Watching or Watching -/?.

This PR simply replaces - with empty string which later will be trimmed in such type of list entries statuses. It doesn't affect entries with On-Hold status since they don't have space before dash, and no other status on MAL have dashes in it.

Example in my profile https://myanimelist.net/profile/N0D4N
image
Plan To Watch entries are displayed with just status.
Reading with non zero progress but unknown total chapters is displayed as Reading 3/?
Dropped with zero progress and known total chapters is displayed as Dropped -/58
Completed with zero progress and zero total chapters is displayed as Completed -

@irfan-dahir irfan-dahir merged commit 0ac1ac3 into jikan-me:3.0.0 Apr 12, 2021
@irfan-dahir
Copy link
Collaborator

That was quick, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants