Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharacterListItem missing getter for CharacterMeta #375

Closed
ToshY opened this issue Dec 6, 2021 · 2 comments
Closed

CharacterListItem missing getter for CharacterMeta #375

ToshY opened this issue Dec 6, 2021 · 2 comments

Comments

@ToshY
Copy link
Contributor

ToshY commented Dec 6, 2021

Summary
In v3 it's no longer possible to get important character data like the malId, url, images, and name from CharacterListItem, as the functionality seems to be replaced with CharacterMeta. But there's no getter available for this data, so it's impossible to get character info.

Solution
Add getter for character.

/**
 * @return CharacterMeta
 */
public function getCharacter(): CharacterMeta
{
    return $this->character;
}

Version
v3.0.0-beta.8

@ToshY
Copy link
Contributor Author

ToshY commented Dec 6, 2021

I took the liberty to add a PR because I actually want this fixed as soon as possible. Is it possible to merge it and tag a new beta release?

@irfan-dahir
Copy link
Collaborator

Thanks for the PR and good catch! I've merged and released v3.0.0-beta.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants