Merge pull request #512 from jikan-me/enhancement/person/given-name

Person: Given name set as null if empty
jikan-me · Apr 14, 2023 · e64a336 · e64a336
2 parents 0ea3b62 + d85489f
commit e64a336
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/Parser/Person/PersonParser.php b/src/Parser/Person/PersonParser.php
@@ -96,9 +96,15 @@ public function getPersonGivenName(): ?string
             return null;
         }
 
-        return JString::cleanse(
+        $givenName = JString::cleanse(
             str_replace($node->text(), '', $node->ancestors()->text())
         );
+
+        if (empty($givenName)) {
+            return null;
+        }
+
+        return $givenName;
     }
 
     /**