Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete add pom and wrapper modules #2472

Closed
DamnClin opened this issue Jul 10, 2022 · 3 comments · Fixed by #2486
Closed

Delete add pom and wrapper modules #2472

DamnClin opened this issue Jul 10, 2022 · 3 comments · Fixed by #2486

Comments

@DamnClin
Copy link
Collaborator

We have the maven init module which adds a base pom.xml and the maven wrapper, then two dedicated module. One for the pom and one for the wrapper. I think this is kinda missleading and that we should just keep the init module. What do you think @pascalgrimaud ?

@pascalgrimaud
Copy link
Member

Don't understand well.

  1. Do you suggest to merge init and maven into 1 single module ?
  2. Or do you suggest to keep 1 single module for maven, which will generate pom.xml + wrapper? Instead of having 2 different sub modules

@DamnClin
Copy link
Collaborator Author

We currently have 3 maven module:

  • maven pom (add a pom)
  • maven wrapper (add maven wrapper)
  • maven init (the 2 previous ones)

My suggestion is to only keep maven init

@pascalgrimaud
Copy link
Member

Agree, let's keep only maven init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants