Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Remove ngx-webstorage dependency #2458

Closed
wmarques opened this issue Jul 9, 2022 · 1 comment · Fixed by #2747
Closed

Angular: Remove ngx-webstorage dependency #2458

wmarques opened this issue Jul 9, 2022 · 1 comment · Fixed by #2747
Assignees
@qmonmert
Labels
area: enhancement 🔧 client: angular

Comments

@wmarques
Copy link
Contributor

wmarques commented Jul 9, 2022

I saw that we use the lib ngx-webstorage in order to access LocalStorage and SessionStorage.
I find it quite overkill as it's very easy to access those with plain JavaScript, that's why I suggest to remove this lib and replace it with vanilla JS.

WDYT ? ping @qmonmert
@qmonmert
Copy link
Contributor

@wmarques I agree with you. I used ngx-webstorage like in the generator, but no problem to remove it.

@qmonmert qmonmert self-assigned this Jul 23, 2022
@qmonmert qmonmert mentioned this issue Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qmonmert qmonmert

Labels
area: enhancement 🔧 client: angular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Angular: Remove ngx-webstorage dependency qmonmert/jhipster-lite
3 participants
@wmarques @pascalgrimaud @qmonmert