Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: logs page #1653

Open
pascalgrimaud opened this issue May 7, 2022 · 4 comments
Open

Angular: logs page #1653

pascalgrimaud opened this issue May 7, 2022 · 4 comments

Comments

@pascalgrimaud
Copy link
Member

After generating Angular as client, it could be nice to have the possibility to generate logs page:

  • entry in menu
  • log html
  • log component
  • log service
  • log tests

SImilar to:
image

@NicolasDesnoust
Copy link

Hello @pascalgrimaud and @qmonmert, I would like to contribute to this issue by following what has been implemented in #1652, is this possible ?

@qmonmert
Copy link
Contributor

@NicolasDesnoust yes it is possible :) it would be good to wait that the #1652 be merged because this PR lays the foundations

@NicolasDesnoust
Copy link

Indeed, I agree

@pascalgrimaud
Copy link
Member Author

Thanks a lot @NicolasDesnoust !
You're welcome to contribute

As @qmonmert mentionned, you can wait but it's not a problem if you decide to start it, as the current system should allow this. You can work on the logs page, without waiting another PR to be finished

Then, there are 2 distinct approach here:

  • use the same system than in health page
  • try to use the new module system, which was init by @DamnClin -> it can work for adding new files and regexp some texts

I'd prefer the 2nd approach as it's more "fluent" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@pascalgrimaud @qmonmert @NicolasDesnoust and others