Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More REST compliant APIs #144

Closed
hdurix opened this issue Oct 29, 2021 · 10 comments
Closed

More REST compliant APIs #144

hdurix opened this issue Oct 29, 2021 · 10 comments

Comments

@hdurix
Copy link
Member

hdurix commented Oct 29, 2021

Rework on REST APIs to be self explaining (proposition will follow)

@fdelbrayelle
Copy link
Contributor

Yep, routes should not contains any verb IMHO.

@pascalgrimaud
Copy link
Member

any suggestions are welcome !

@pascalgrimaud
Copy link
Member

I know our current APIs are not so nice, but without any suggestions, it can't be improved.
So your opinions are needed here, @fdelbrayelle @hdurix

@fdelbrayelle
Copy link
Contributor

@hdurix Maybe we can discuss this soon?

@hdurix
Copy link
Member Author

hdurix commented Apr 8, 2022

today? :)

@hdurix
Copy link
Member Author

hdurix commented Apr 8, 2022

Things I have in mind:

  • add /clients before Vue.js, React, angular... As we have /servers/ for servers API:
    • /api/servers/spring-boot is compliant
    • /api/vue is not compliant
  • try to have something like <collection>/<id>/<collection>/<id>/.../<element> (URL "leaf" can be either a collection, an id or an element):
    • /api/servers/spring-boot/databases/mysql is compliant
    • /api/svelte/styled is not compliant
  • maybe try try to thing about using request bodies to specify some options like:
    • /api/servers/spring-boot/banner with a required request body attribute of the wanted type instead of /api/servers/spring-boot/banner/jhipster-v2 & others
    • merge /api/servers/sonar/java-backend and /api/servers/sonar/java-backend-and-frontend in /api/servers/sonar (btw, sonar is not a server, this could also be changed)

@pascalgrimaud
Copy link
Member

some good idea here
To ease this ticket, it's better to improve each context in separated PR, it will be easier to review and discuss

@hdurix
Copy link
Member Author

hdurix commented Apr 8, 2022

OK I'm creating a ticket by topic.

@DamnClin
Copy link
Collaborator

I think the work on modules covers that, what do you think about closing that and keep migrating modules?

@pascalgrimaud
Copy link
Member

yes, let's migrate everything to modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants