Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: utils methods #1301

Closed
pascalgrimaud opened this issue Apr 10, 2022 · 7 comments
Closed

Gradle: utils methods #1301

pascalgrimaud opened this issue Apr 10, 2022 · 7 comments

Comments

@pascalgrimaud
Copy link
Member

Similar to what was done for Maven, this ticket is for adding different utils methods:
https://github.com/jhipster/jhipster-lite/blob/main/src/main/java/tech/jhipster/lite/generator/buildtool/maven/domain/MavenService.java#L11

At the same time, for each methods, we need to add the entry in https://github.com/jhipster/jhipster-lite/blob/main/src/main/java/tech/jhipster/lite/generator/buildtool/generic/domain/BuildToolDomainService.java

@pascalgrimaud pascalgrimaud added area: enhancement 🔧 theme: gradle $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Apr 10, 2022
@atomfrede
Copy link
Member

You can assign it to me, already started something.

@lucasmippon
Copy link
Contributor

Currently reading source (Maven and Gradle) to have a first insight on what has been done and see if I can start something.

@atomfrede
Copy link
Member

I have already started small things. Hope to create a first PR during the weekend. If you find time before please go ahead.

@lucasmippon
Copy link
Contributor

lucasmippon commented May 12, 2022

To do

@pascalgrimaud, I have some question :

  • It look like the Parent relationship doesn't exist in Gradle, should we throw an error for it ?
  • It look like dependencyManagement mechanism in Maven help to have simpler child POM. Do you know if an equivalent thing exist for Gradle and do you have an hint on how it should be done ?
  • It look like plugin repository declaration can't be separated from plugin declaration in Gradle, how should I handle this ? Knowing that BuildToolService.addPluginRepository(Project project, Repository repository) doesn't have a plugin as argument ?

@atomfrede
Copy link
Member

I will try to answer your questions later.

@pascalgrimaud
Copy link
Member Author

In fact, I'm not a user Gradle, so I don't know. It's really cool if you can help here @atomfrede , thanks :-)

@pascalgrimaud pascalgrimaud removed $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Jul 23, 2022
@pascalgrimaud
Copy link
Member Author

I'm removing the bounty and move it to #1862
The work should be done in the module system so let's close this one in favor of #1862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants