Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate build server process and running with client part in dev and prod mode for monolithic app #23

Closed
ghost opened this issue Aug 20, 2019 · 3 comments · Fixed by #29
Labels
Feature New feature
Milestone

Comments

@ghost
Copy link

ghost commented Aug 20, 2019

For the application type that is not monolithic with client, has already the maven command to run the entire project. Now it's necessary to include the client build in the server running (and build) exposed by NestJS

@ghost ghost self-assigned this Aug 20, 2019
@ghost ghost added the Feature New feature label Aug 20, 2019
@ghost ghost changed the title Integrate build server process and running with client part in dev and prod mode Integrate build server process and running with client part in dev and prod mode for monolithic app Aug 20, 2019
@ghost
Copy link
Author

ghost commented Aug 21, 2019

The status is quite complete. The maven dev profile runs the build in serve mode exposing static client resources, while the prod profile build all (client and server parts) under server/dist folder. The only problem is that the client standard jhipster build with webpack (webpack:prod), controls in compile time also the typescript files under the server folder, giving problems for the server node_modules with nestjs annotation (in particular nestjs/swagger apiTags and authBearer annotations)

@ghost
Copy link
Author

ghost commented Aug 23, 2019

About the issue of the webpack client that includes also the server folder, there is a workaround

@ghost
Copy link
Author

ghost commented Aug 23, 2019

I have tested. The solution is to include in all tsconfig.json this exclusion:

"exclude": ["node_modules", "server"]

@ghost ghost mentioned this issue Aug 25, 2019
@ghost ghost closed this as completed in #29 Aug 25, 2019
@ghost ghost added this to the 1.0.0-alpha.1 milestone Sep 19, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants