Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons with 'navbar-burger' have border radius. #1580

Closed
ek1506 opened this issue Jan 1, 2018 · 2 comments
Closed

Buttons with 'navbar-burger' have border radius. #1580

ek1506 opened this issue Jan 1, 2018 · 2 comments
Labels

Comments

@ek1506
Copy link

ek1506 commented Jan 1, 2018

This is about Bulma.

Overview of the problem

Button elements with the class combination of 'button' and 'navbar-burger' have border radius.

Description

This was discussed in #1515, but their workaround was to remove the 'button' class and use a <div> tag. This workaround is not sufficient for all cases, because you lose access to modifiers like 'is-primary'.

A solution is to remove the border radius from 'navbar-burger', so it can be safely used in combination with 'button'.

Expected behavior

image1

Actual behavior

image2

@feute
Copy link
Contributor

feute commented Jan 1, 2018

I never thought about colour modifiers like is-primary on the hamburger. Good point.

Maybe you could use the modifier is-radiusless as a workaround. I agree that navbar-burger shouldn't have a radius (or border) if it's a button.

@stale
Copy link

stale bot commented Jan 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2019
@stale stale bot closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants