Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML label not in the good place in embed mode since v13 #989

Closed
algenty opened this issue Jun 18, 2020 · 5 comments
Closed

HTML label not in the good place in embed mode since v13 #989

algenty opened this issue Jun 18, 2020 · 5 comments

Comments

@algenty
Copy link

algenty commented Jun 18, 2020

Hi,

I already wrote an issue about this at
#940

Without news, i had investigate and i found a solution.
In mxSvgCanvas2D.js function updateTextNodes
i replaced :
'display: flex; align-items: unsafe ' +
By
'display: flex; align-self: unsafe ' +

Before with align-items
image

After with align-self :
image

BR,
Arnaud

@alderg
Copy link
Contributor

alderg commented Jun 18, 2020

Thanks for this. It seems to break one of our test cases. We need to understand why this breaks your output in #940 in the first place, maybe the container affects the output. Can you provide a standalone example that reproduces this problem?

@algenty
Copy link
Author

algenty commented Jun 18, 2020

I have created an example of bug on
https://play.grafana.org/d/NpjdeVWGz/flowcharting-bug-draw-io-940?orgId=1
I think you know the used template.

PS : You can found other examples of flowcharting with drawio at
https://play.grafana.org/d/Unu5JcjWk/flowcharting-index?orgId=1

Thx again for draw.io

@algenty
Copy link
Author

algenty commented Jun 18, 2020

To change align-items by align-self is not the solution, it generates others problems
image

I think the calculate of padding-top is not good
flex += 'padding-top: ' + yp + 'px; ';

With mxgraph 4.0.0 align-items doesn't exist,

@alderg
Copy link
Contributor

alderg commented Jun 19, 2020

Screenshot 2020-06-19 at 06 48 45
This CSS style seems to be causing the problem on the first DIV in the foreignObject.

@algenty
Copy link
Author

algenty commented Jun 19, 2020

You're right !
I can't modify this css because i'm not the owner but if i add
-webkit-box-sizing : content-box
on my parent div, it works !! Thx a lot

thx for your investigation
You are a chef !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants