Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Webhook Creation Criteria to behave more like UI/API #1213

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhadertelekom
Copy link

Update Webhook Creation Criteria to Align with Artifactory UI/API Behavior

Description:

Currently the creation of release-bundle-webhook-resources has a different policy inside the terraform provider than in the API or UI. The field "registered_release_bundle_names" is mandatory inside the terraform provider. UI/API behave differently.

This pull request:

  1. Refines the webhook creation logic in the Terraform provider for Artifactory to better align with the behavior of the Artifactory UI and API
  2. Aligns the tests that are done in the Terraform provider according to the changes from (1)
  3. Updates the documentation accordingly

These improvements ensure a more intuitive user experience for customers managing Artifactory webhooks via Terraform.

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@alexhung alexhung added the enhancement New feature or request label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants