Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RSA and PGP keys from tests #1173

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Remove RSA and PGP keys from tests #1173

merged 3 commits into from
Jan 15, 2025

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented Jan 15, 2025 •
edited
Loading

Now import them from env vars. For GitHub Actions, they are set from GH environment's secret context.

@alexhung
Remove RSA and PGP keys from tests
6980fce 
Now import them from env vars
@alexhung alexhung added the enhancement New feature or request label Jan 15, 2025
@alexhung alexhung marked this pull request as ready for review January 15, 2025 19:51
@alexhung alexhung requested a review from danielmkn as a code owner January 15, 2025 19:51
@alexhung alexhung merged commit b0a18ec into master Jan 15, 2025
7 of 8 checks passed
@alexhung alexhung deleted the remove-pgp-keys-from-tests branch January 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkn danielmkn danielmkn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhung @danielmkn