Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new machinelearning package type to local repository #1152

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Add new machinelearning package type to local repository #1152

merged 8 commits into from
Dec 17, 2024

Conversation

alexhung
Copy link
Member

  • Also migrate all 'generic-like' package types to Plugin Framework
  • Move generic repo tests to own file
  • Refractor generic repo code to use Plugin Framework (some duplicate code remains to be DRY-ed)
  • Implement validation for project_environments attribute at BaseResource

@alexhung alexhung added the enhancement New feature or request label Dec 16, 2024
alexhung and others added 8 commits December 16, 2024 10:49
@alexhung
Add machinelearning package type to local repository
34f165b 
Lay down foundational code for repository resource using Plugin Framework, for future migration of repository resources from SDKv2.

Remove SDKv2 dependency from test functions.
@alexhung
Migrate all local generic like package type repos to Plugin Framework
d70317f 
Move generic repo tests to own file

Refractor generic repo code to use Plugin Framework (some duplicate code remains to be DRY-ed)

Implement validation for project_environments attribute at BaseResource
@alexhung
DRY the CRUD methods
0016739 
Use reflect.Type and interface to enable correct marshaling/unmarshaling of TF data.
@alexhung
Add SDKv2 migration test
c647519
@alexhung
Update CHANGELOG
8fbd874
@alexhung
Add ID attribute for backward compatibility
79040d9 
Fix datasource test for generic local repos
@alexhung
Set 'id' attribute during update
778853d
@jfrogsolutioncicd @alexhung
JFrog Pipelines - Add Artifactory version to CHANGELOG.md
1a721be
@alexhung alexhung force-pushed the add-new-repository-package-types branch from 7366f8b to 1a721be Compare December 16, 2024 18:49
@alexhung alexhung marked this pull request as ready for review December 16, 2024 18:49
@alexhung alexhung requested a review from danielmkn as a code owner December 16, 2024 18:49
@alexhung alexhung merged commit b422ea1 into master Dec 17, 2024
8 checks passed
@alexhung alexhung deleted the add-new-repository-package-types branch December 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkn danielmkn danielmkn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexhung @danielmkn @jfrogsolutioncicd