-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: punycode deprecation warning on Node 22 LTS #15367
Comments
relevant #15276 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
(no activity indeed) |
Jest feels abandoned ): |
It looks like that. Are you going to replace it with something else? What are the options? |
@ginosanterre https://github.com/vitest-dev/vitest is currently the most popular option |
Anyone successfully patch this? |
This clumsy npm overrides works for our app. It also fixes punycode problem in other our deps. packages.
|
@MirKml where did you write that snippet? I've already looked into the pakage.json and similar files, but I could not get a hint of where should I write that code snippet. Many thanks in advance to anyone who cold answer. |
@LiviuSosu into package.json. Overrides are supported by npm itself https://docs.npmjs.com/cli/v10/configuring-npm/package-json#overrides NPM has also some bugs in overrides implementation, |
You don't need overrides, just update |
Not sure what kind of answer is that. Even if it works for Which at the time of writing, requires |
Hi @alfaproject @MirKml clarified for me whete to put the code snippet. It fixed my problem (or hid it, as I am using npm) but he also stated that it is a clumsy solution. I am working on a side project for learning purposes, so... thank you again MirKml. I didn't want to coment because I feared reopening the issue. @SimenB , with a due respect and regret, I didn't get your answer, in case @alfaproject is reffering to yours. Maybe you could explain it for someone who doesn't have your knowlegde. For example " just update psl in your lockfile (or tough-cookie ..." there are my psls in my package.lockfile.json. I don't know which one I should update and expecially how (what should I write instead)? |
JSDOM doesn't lock down its version of |
@SimenB I think you missed the rest of my reply. This is the version that matches |
also, my packages are always up to date. I am cecking for updates on a weekly basis. |
Updating |
I see, that makes sense and I'm an idiot. Sorry for the noise |
Fine that psl is solved, but I think
Problematic
So I think problem isn't solved and issue needs to be reopen. |
some CSS parsing problems with jsdom<26.0.0 too because of not supporting @layer and so on... Maybe there is something I don't understand but why don't we want to keep dependencies up to date? Is this version too invasive? |
Version
29.7.0
Steps to reproduce
Run any test suite with jest environment jsdom using Node 22.
Expected behavior
No deprecation warning is printed.
Actual behavior
The following warning is printed before tests run.
Additional context
This problem is also mentioned in #15148, but while upgrading jest-environment-jsdom is a possible solution, I'd like to specifically track the deprecation warning happening on the stable release (#15148 seems to be about the alpha release).
Environment
System:
OS: macOS 15.0.1
CPU: (12) arm64 Apple M2 Pro
Binaries:
Node: 22.11.0 - ~/.local/state/fnm_multishells/98505_1730127764871/bin/node
npm: 10.9.0 - ~/.local/state/fnm_multishells/98505_1730127764871/bin/npm
npmPackages:
jest: ^29.7.0 => 29.7.0
The text was updated successfully, but these errors were encountered: