From 775e75d8e7bb9f1275912da94ac7a6b92796cdd1 Mon Sep 17 00:00:00 2001 From: Fumihiro Xue Date: Tue, 5 Dec 2017 11:38:28 +0800 Subject: [PATCH] fix: add argument node checks Closes #29 --- rules/__tests__/prefer_to_be_null.test.js | 2 +- rules/util.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/rules/__tests__/prefer_to_be_null.test.js b/rules/__tests__/prefer_to_be_null.test.js index 944c4c971..c1d2ce0dd 100644 --- a/rules/__tests__/prefer_to_be_null.test.js +++ b/rules/__tests__/prefer_to_be_null.test.js @@ -6,7 +6,7 @@ const rules = require('../../').rules; const ruleTester = new RuleTester(); ruleTester.run('prefer_to_be_null', rules['prefer-to-be-null'], { - valid: ['expect(null).toBeNull();'], + valid: ['expect(null).toBeNull();', 'expect(null).toEqual();'], invalid: [ { diff --git a/rules/util.js b/rules/util.js index 0eed7a29b..9d049e021 100644 --- a/rules/util.js +++ b/rules/util.js @@ -26,22 +26,26 @@ const expectToBeCase = (node, arg) => !(expectNotCase(node) || expectResolveCase(node) || expectRejectCase(node)) && expectCase(node) && methodName(node) === 'toBe' && + argument(node) && argument(node).value === arg; const expectNotToBeCase = (node, arg) => expectNotCase(node) && methodName2(node) === 'toBe' && + argument2(node) && argument2(node).value === arg; const expectToEqualCase = (node, arg) => !(expectNotCase(node) || expectResolveCase(node) || expectRejectCase(node)) && expectCase(node) && methodName(node) === 'toEqual' && + argument(node) && argument(node).value === arg; const expectNotToEqualCase = (node, arg) => expectNotCase(node) && methodName2(node) === 'toEqual' && + argument2(node) && argument2(node).value === arg; const expectToBeUndefinedCase = node =>