Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view doesn't seem to be working #1227

Closed
kalvinpearce opened this issue Apr 7, 2021 · 7 comments
Closed

Tree view doesn't seem to be working #1227

kalvinpearce opened this issue Apr 7, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@kalvinpearce
Copy link
Contributor

Describe the bug
I just saw #1197 got merged in 0.27 (been suuuuuuper keen for this feature) and updated to try it out but pressing ` key doesn't seem to do anything. I have also tried to select the toggle file tree view menu option and it also doesn't change anything. I have also tried changing the config setting to true, with no luck.

Screenshots

image

Screenshot is from within neovim but have tried running standalone from powershell with the same problem.

Desktop:

  • OS: Windows 10
  • Lazygit Version 0.27
@kalvinpearce kalvinpearce added the bug Something isn't working label Apr 7, 2021
@mjarkk
Copy link
Contributor

mjarkk commented Apr 7, 2021

Just pulled in the latest master and it works perfectly fine on mac os.

Maybe there is some problem with tcell's ` key on windows,
Can you try to add something like this to the config file:

keybinding:
    files:
        toggleTreeView: 't'

The config file is located at: %APPDATA%\jesseduffield\lazygit\config.yml
Or inside lazygit go to the status tab and press e

@kalvinpearce
Copy link
Contributor Author

I have just tried the keybinding change now and still same issue, unfortunately

@jesseduffield
Copy link
Owner

There will be times when the tree appears flat because there is no directory that contains multiple children, however in your screenshot that does not appear to be the case. I wonder why it wouldn't work on windows. Maybe the code is assuming forward slashes as path separators somewhere. In fact that's almost certainly what it is haha

@jesseduffield
Copy link
Owner

@kalvinpearce can you see if your issue is resolved on the latest master? I just tested it on my PC and it worked for me

@kalvinpearce
Copy link
Contributor Author

🙏 beautiful! working like a charm. On a small side note, I don't suppose theres a way to collapse those tree nodes is there? Could be a nice addition if not but absolutely this does wonders for readability and I am keen to use lazygit more as my primaray git interface

@kalvinpearce
Copy link
Contributor Author

Never mind i just found the folding 🙏 you are a legend!!!

@jesseduffield
Copy link
Owner

Pleasure to be of service!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants