Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable on PDF pages and on chrome web store page #3

Open
jeromepl opened this issue Jul 16, 2019 · 1 comment
Open

Disable on PDF pages and on chrome web store page #3

jeromepl opened this issue Jul 16, 2019 · 1 comment
Assignees

Comments

@jeromepl
Copy link
Owner

Users are expecting this to work on PDFs, but I haven't found a way to make that work yet. For now, disable the extension on open PDF pages.
Should be a simple change to the manifest.

@jeromepl jeromepl self-assigned this Mar 18, 2020
@jeromepl
Copy link
Owner Author

jeromepl commented Jun 9, 2020

Needs a bit more than a change to the manifest:

  • content scripts can be disabled from the manifest using "exclude_matches": ["*://*/*.pdf"], but that assumes that every path that ends with .pdf is actually a pdf...
  • context menus need to be disabled through the api chrome.contextMenus.create
  • the popup icon can be grayed out through a browser action (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant