Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP version #98

Closed
to-be-the-best opened this issue Sep 19, 2017 · 4 comments
Closed

PHP version #98

to-be-the-best opened this issue Sep 19, 2017 · 4 comments

Comments

@to-be-the-best
Copy link

I noticed that in the composer file a PHP version of 5.3.3 is still accepted, while the code actually uses version 5.4 and above, meaning the code is no longer running at 5.3.3.
Personally, I would like to follow the example of Symfony 3 and increase the php version in the composer file to 5.5.9.
I am very curious about your opinion.
@to-be-the-best
Copy link
Author

If you want, I can make a pull request with my proposal.
This would be with php version 5.5.9.

@to-be-the-best
Copy link
Author

@jeroendesloovere If you do not want this, please say it, I'll do it on my own fork the way I think it should.

@jeroendesloovere
Copy link
Owner

Hi @to-be-the-best a PR is always welcome.

@to-be-the-best to-be-the-best mentioned this issue Dec 9, 2017
Closed
@jeroendesloovere
Copy link
Owner

Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeroendesloovere @to-be-the-best