Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Required parameter $element follows optional parameter $include in ....vendor/jeroendesloovere/vcard/src/VCard.php on line 228 #181

Closed
nabeelalihashmi opened this issue May 25, 2021 · 6 comments

Comments

@nabeelalihashmi
Copy link

I get this issue.

Fix:
File: vendor/jeroendesloovere/vcard/src/VCard.php | line 228: private function addMedia($property, $url, $element,$include = true)
vendor/jeroendesloovere/vcard/src/VCard.php | lines 432-442: public function addLogo($url, $include = true)
{
$this->addMedia(
'LOGO',
$url,
'logo',
$include
);

    return $this;
}
@iamkbkarthikeyan
Copy link

Hi, @nabeelalihashmi Same Happend on my PHP 8.

@nadeem706
Copy link

@iamkbkarthikeyan same happend to me on php8. You have any alternate solution for it?

@tringalama2
Copy link
Contributor

same issue. it is a compatibility issue with PHP 8.0.

I made the fix, updated composer.json to PHP 8 and PHPUnit to 9.3 and submitted a pull request.

in the meantime, you can use my fork: https://github.com/tringalama2/vcard

this is my first pull request, so any suggestions are welcome.

@jeroendesloovere
Copy link
Owner

Another MR fixes it: #192

@jeroendesloovere
Copy link
Owner

@tringalama2 can you create a pull request to update php to 9.3?

@steccas
Copy link

steccas commented Jul 21, 2023

This is not resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants