Open to PR with Additional Logging?

[sghill]

I'd like to add additional logging to this plugin to gain some insight around the decisions it's making to send notifications. I'm happy to submit a PR, but first I thought I'd ask: is that likely to be accepted?

For example, the logic in ActiveNotifier.java#L123 is quite complex. Occasionally we'll troubleshoot something like notifications not coming through for multiple failed builds in a row, only to realize the advanced setting 'Notify on Repeated Failure' was not checked. If there were logs we could look to when a question arose, it'd really shorten the troubleshooting process.

There are places where logs exist that I'd like to be more detailed as well. For example ActiveNotifier.java#L182 has

logger.info("No change set computed...");

but this is in the context of a build, and it'd be really helpful to have that information present when troubleshooting a particular job:

logger.info("No change set computed for $projectName#$buildNumber");

[jetersen]

Again I think office365 plugin does it best or at least tries to 😄
We avoided the while loop so that's an improvement.
https://github.com/jenkinsci/office-365-connector-plugin/blob/master/src/main/java/jenkins/plugins/office365connector/Office365ConnectorWebhookNotifier.java#L152

This could use a rewrite to use the parent class Run instead of AbstractBuild

slack-plugin/src/main/java/jenkins/plugins/slack/ActiveNotifier.java

Line 180 in 15aea13

String getChanges(AbstractBuild r, boolean includeCustomMessage) {

[timja]

I'm scared to touch that code (also I don't use that functionality so I'm less likely to notice if something goes wrong there) but a PR would certainly be accepted that refactors it

@Casz's example is much better code than the state this part of the code currently is in