Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespaceOverride not applied when loading JCasC #237

Closed
jayfo opened this issue Jan 30, 2021 · 1 comment · Fixed by #238
Closed

namespaceOverride not applied when loading JCasC #237

jayfo opened this issue Jan 30, 2021 · 1 comment · Fixed by #238
Labels
bug Something isn't working

Comments

@jayfo
Copy link
Contributor

jayfo commented Jan 30, 2021

Describe the bug:

When namespaceOverride is set, all JCasC fails. Travis instead starts with a default configuration (e.g., with no security).

This is because the override is not applied when configuring the sidecar.

Which version of the chart:

3.1.4

How to reproduce it:

values.yaml

namespaceOverride: 'jenkins'
helm install my-release jenkins/jenkins --version version --values values.yaml

Anything else we need to know:

Workaround is to set controller.sidecars.configAutoReload.searchNamespace to the same value as namespaceOverride. But this does appear to be a bug, as the documentation for controller.sidecars.configAutoReload.searchNamespace clearly states:

# If specified, the sidecar will search for JCasC config-maps inside this namespace.
# Otherwise the namespace in which the sidecar is running will be used.
@jayfo jayfo added the bug Something isn't working label Jan 30, 2021
@jayfo
Copy link
Contributor Author

jayfo commented Jan 30, 2021

I will attempt a small fix on this, looks very straightforward.

@jayfo jayfo changed the title namespaceOverride not applied to when loading JCasC namespaceOverride not applied when loading JCasC Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant