Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Framework for New JSON Schema #997

Closed
3 tasks
sladyn98 opened this issue Aug 23, 2019 · 2 comments · Fixed by #1027 or #1078
Closed
3 tasks

Test Framework for New JSON Schema #997

sladyn98 opened this issue Aug 23, 2019 · 2 comments · Fixed by #1027 or #1078
Assignees
Labels
dev-tools JCasC Community Bridge Dev-Tools Project

Comments

@sladyn98
Copy link

sladyn98 commented Aug 23, 2019

As suggested by @oleg-nenashev #1027 (comment)
We would be adding Unit tests for the Schema.
Inital plans:

  • Add examples in tests for valid and invalid configurators , could be typos etc.

  • Add examples in tests for valid and invalid data types, eg int , string.

  • Separate Test for the testing the schema Generated is valid.

@sladyn98 sladyn98 added the dev-tools JCasC Community Bridge Dev-Tools Project label Aug 23, 2019
@sladyn98 sladyn98 self-assigned this Aug 23, 2019
@sladyn98 sladyn98 changed the title Schema Tests for Generated Schema Test Framework for New JSON Schema Sep 1, 2019
@oleg-nenashev
Copy link
Member

One comment here: Test Framework != Tests. Test framework is supposed to simplify writing tests by moving common logic into various utility methods. Is this part considered here?

@sladyn98
Copy link
Author

Yeah we would just have to add a file and call a few common methods. I could include it in the next PR of the next schema. So to answer your question It has been considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools JCasC Community Bridge Dev-Tools Project
Projects
None yet
2 participants