Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new JCasC Test Harness Library #917

Closed
1 task
oleg-nenashev opened this issue Jun 7, 2019 · 5 comments
Closed
1 task

Introduce a new JCasC Test Harness Library #917

oleg-nenashev opened this issue Jun 7, 2019 · 5 comments
Labels
test A PR that adds to testing - used by Release Drafter

Comments

@oleg-nenashev
Copy link
Member

Your checklist for this issue

🚨 Please review the guidelines for contributing to this repository.

  • Link to any upstream changes that might be required (for example Jenkins Core pull request)

Feature Request

It looks like we have a lot of test framework functionality for JCasC:

Currently it is hard to reuse this code, because it is located within the test suites, so an odd dependency is needed. Also, it makes the downstream plugins to pull in more test dependencies than we really want.

    <dependency>
      <groupId>io.jenkins</groupId>
      <artifactId>configuration-as-code</artifactId>
      <version>${configuration-as-code.version}</version>
      <classifier>tests</classifier>
      <scope>test</scope>
    </dependency>

What if we introduce a new configuration-as-code-test-harness component which would ship it in a library?

    <dependency>
      <groupId>io.jenkins</groupId>
      <artifactId>configuration-as-code-test-harness</artifactId>
      <version>${configuration-as-code.version}</version>
      <scope>test</scope>
    </dependency>
@oleg-nenashev oleg-nenashev added feature A PR that adds a feature - used by Release Drafter test A PR that adds to testing - used by Release Drafter labels Jun 7, 2019
@timja
Copy link
Member

timja commented Jun 7, 2019

Yes, I believe we discussed it before, last time there was a packaging issue with the test classifier, we did the quick fix at the time but a separate module would be good in my opinion

@MRamonLeon
Copy link
Contributor

LGTM ❤️

@timja
Copy link
Member

timja commented Dec 10, 2019

resolved in #1215

@timja timja closed this as completed Dec 10, 2019
@oleg-nenashev
Copy link
Member Author

I believe it is fixed by @timja in #1215

@oleg-nenashev
Copy link
Member Author

ERR_RACE_CONDITION

@timja timja removed the feature A PR that adds a feature - used by Release Drafter label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A PR that adds to testing - used by Release Drafter
Projects
None yet
Development

No branches or pull requests

3 participants