jx boot adds ingress definitions into environments section in jx-requirements.yaml

[sdoxsee]

Summary

Clone/fork the jenkins-x-boot-config github repo. Run jx boot and the environments node in jx-requirements.yaml gets a bunch of (unused?) ingress definitions.

Slack Reference: https://kubernetes.slack.com/archives/C9MBGQJRH/p1568110165241000?thread_ts=1568102025.228600&cid=C9MBGQJRH

example of corrupted jx-requirements.yaml section:

environments:
- ingress:
    domain: rhervas.info
    externalDNS: true
    namespaceSubDomain: ""
    tls:
      email: <user>@gmail.com
      enabled: true
      production: true
  key: dev
- ingress:
    domain: rhervas.info
    externalDNS: true
    namespaceSubDomain: ""
    tls:
      email: <user>@gmail.com
      enabled: true
      production: true
  key: staging
- ingress:
    domain: rhervas.info
    externalDNS: true
    namespaceSubDomain: ""
    tls:
      email: <user>@gmail.com
      enabled: true
      production: true
  key: production

Expected behavior

should look more like this:

environments:
- key: dev
- key: staging
- key: production

Jx version

2.0.758

Jenkins type

• Serverless Jenkins X Pipelines (Tekton + Prow)
• Classic Jenkins

Kubernetes cluster

GKE (jx create cluster gke --skip-installation)

Operating system / Environment

OSX

[ccojocar]

This change is part of a fix for #5310. See the PR #5362.

The aim is to make ingress configurable per environment in order to be able to enable TLS for dedicated environment domains.

@deanesmith I wouldn't mark this as a bug but rather close it.