Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s CustomResource previews.preview.jenkins.io contains a field cloneURL with credentials #172

Open
yelhouti opened this issue Dec 12, 2020 · 0 comments
Open

k8s CustomResource previews.preview.jenkins.io contains a field cloneURL with credentials #172

yelhouti opened this issue Dec 12, 2020 · 0 comments

Comments

@yelhouti
Copy link
Contributor

k8s CustomResource previews.preview.jenkins.io should not contain the credentials IMO.
The caller (ex: jx preview gc) should retrieve them from secret and change the url instead of saving credentials in plain text (the same way it's done in the first place to create the cloneURL now).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yelhouti