Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon.nl #availability conflict (div id) #1366

Closed
SWEETDREAMSIV opened this issue Dec 12, 2020 · 1 comment
Closed

Amazon.nl #availability conflict (div id) #1366

SWEETDREAMSIV opened this issue Dec 12, 2020 · 1 comment

Comments

@SWEETDREAMSIV
Copy link

Expected Behavior

find the products in stock correctly.

Current Behavior

at the moment using #availability as container there are false positives especially in the 'op voorraad' comparison

inStock: {
			container: '#availability',
			text: [
				'op voorraad',
				'verkrijgbaar vanaf',
				'wordt gewoonlijk verzonden binnen',
				'nog slechts'

Immagine

[13:42:43] info :: 🚀🚨 [amazon-nl] [zotac (3060ti)] twin edge :: IN STOCK 🚨🚀

Possible solution

inStock: {
			container: '#availability',
			text: [
				'op voorraad.',
				'verkrijgbaar vanaf',
				'wordt gewoonlijk verzonden binnen',
				'nog slechts'

I think it is better to work on the class and not on the div id, this solution iis not "clean"

Extra code

all 3060ti of amazon.nl

{
			brand: 'msi',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NW2YJB2&Quantity.1=1',
			model: 'ventus 3x oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NW2YJB2'
		},
		{
			brand: 'msi',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P2DQ28S&Quantity.1=1',
			model: 'ventus 2x oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P2DQ28S'
		},
		{
			brand: 'msi',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NW2YJB2&Quantity.1=1',
			model: 'ventus 2x oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NW2YJB2'
		},
		{
			brand: 'zotac',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P3XJLJJ&Quantity.1=1',
			model: 'twin edge',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P3XJLJJ'
		},
		{
			brand: 'zotac',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P3V572B&Quantity.1=1',
			model: 'twin edge oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P3V572B'
		},
		{
			brand: 'zotac',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P3BJ9Y8&Quantity.1=1',
			model: 'twin edge oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P3BJ9Y8'
		},
		{
			brand: 'gigabyte',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P3JPX8P&Quantity.1=1',
			model: 'eagle',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P3JPX8P'
		},
		{
			brand: 'gigabyte',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NW2X37Z&Quantity.1=1',
			model: 'gaming oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NW2X37Z'
		},
		{
			brand: 'gigabyte',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NW528S1&Quantity.1=1',
			model: 'eagle oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NW528S1'
		},
		{
			brand: 'pny',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NW693LG&Quantity.1=1',
			model: 'xlr8 revel',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NW693LG'
		},
		{
			brand: 'asus',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B083Z5P6TX&Quantity.1=1',
			model: 'tuf oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B083Z5P6TX'
		},
		{
			brand: 'asus',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08NZ4G4T2&Quantity.1=1',
			model: 'tuf oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08NZ4G4T2'
		},
		{
			brand: 'asus',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08P2HBBLX&Quantity.1=1',
			model: 'dual oc',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08P2HBBLX'
		},
		{
			brand: 'evga',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08PDN36R3&Quantity.1=1',
			model: 'ftw3',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08PDN36R3'
		},
		{
			brand: 'evga',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08PDP837W&Quantity.1=1',
			model: 'xc3',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08PDP837W'
		},
		{
			brand: 'evga',
			cartUrl:
				'https://www.amazon.nl/gp/aws/cart/add.html?ASIN.1=B08PDMVPZ4&Quantity.1=1',
			model: 'xc3 black',
			series: '3060ti',
			url:'https://www.amazon.nl/dp/B08PDMVPZ4'
		},

if anyone wants can delete the links not included in the .nl store that refer to 404.

@jef
Copy link
Owner

jef commented Dec 12, 2020

I will get this fixed up. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants