-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change on aqua #3338
Comments
it works for me. Just use the asdf plugin. If you were using the asdf plugin before mise will continue to use that so it's not a breaking change. |
I previously had kubectx installed so it defaults to the asdf plugin backend for me, however I can also recreate the issue when running with
I followed the thread and figgured out why this is happening. The asdf version downloads the "Source code.tar.gz" and uses the bash script version, while the aqua version downloads the proper go compiled binaries for the correct architecture "kubectx_v0.9.5_darwin_arm64.tar.gz" Reading their docs:
And searching for the error the in repo shows a result in the go code. There is an issue in the repo with 46 (now 47 with me) upvotes ahmetb/kubectx#211 |
So it seems we're just now using a newer version of the tool that doesn't have this feature |
tldr; Yes. Before version 0.9.0 https://github.com/ahmetb/kubectx only contained a bash implementation From version 0.9.0 onwards https://github.com/ahmetb/kubectx contains 2 implementations that are released together and supposed to be compatible:
|
@jdx My point here is that I think it's really sad to create breaking change that can't be prevented for the end users for a tool that should always help to get exactly the same CLI. |
Some new peoples following our documentation to get all dependencies are getting |
it's not a breaking change—we're using a new version of a tool which I would argue has a bug in it. I'm definitely going to continue migrating things away from asdf. Once #3339 you will be able to lock the backend into the lockfile. Until then, just specify the full names, e.g.: |
@jdx I think I'm missing some context, |
that's unlikely, no, but I doubt very many new tools will be added that use it |
@jdx In that case, why not keep it as the default source? |
I've explained this in the docs in several places |
@jdx Sorry, I didn't find it, can you give me a link? |
Describe the bug
Since aqua repositories has been added, aqua has been used as default source but some package (as kubectx in my case) does not works with aqua version.
To Reproduce
mise install kubectx@0.9.5 aqua:ahmetb/kubectx
$ kubectx error: kubeconfig error: failed to load: cannot determine kubeconfig path: multiple files in KUBECONFIG are currently not supported
mise install kubectx@0.9.5 asdf:https://gitlab.com/wt0f/asdf-kubectx
Expected behavior
Don't you think
asdf
should be the default source to prevent breaking change?The text was updated successfully, but these errors were encountered: