forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional use of listcredentials for uploading CNF images to Artifact Store #72
Merged
jamiedparsons
merged 9 commits into
add-aosm-extension
from
sunny/credentials-for-cnf-image-upload
Sep 5, 2023
Merged
Optional use of listcredentials for uploading CNF images to Artifact Store #72
jamiedparsons
merged 9 commits into
add-aosm-extension
from
sunny/credentials-for-cnf-image-upload
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for improving a whole bunch of output text - that sort of thing makes a real difference.
Do you think that there is any risk of regressing Windows support here? Worth a quick test?
This was referenced Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
This changes the way image and helm chart upload is done for CNF. The default behaviour is the same as before, i.e. CLI user context permissions are used for helm push and image copy (import). This will fail if the user does not have subscription-wide permissions (documented in params.py and various docstrings).
It adds two optional features:
Additional changes:
az acr import
instead of python ContainerRegistryManagementClient, because we shell out all the time anyway, and that client was a bit of a pain to use, and required knowledge of resource group names. Without it we can just ask the user to provide the ACR login server name.Testing: