Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi-NF failure #187

Merged
merged 3 commits into from
May 9, 2024
Merged

Fix Multi-NF failure #187

merged 3 commits into from
May 9, 2024

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented May 3, 2024


Problem:
When multiple nf RETs were defined in nsd-input.jsonc, there would be 2 RETs in the NSDV but they would be identical, there would also only be one mapping file. This was due to the previous design decision to call the RETs the NSD name and version, instead of the NF name.

Fix:

  • Changed processor and artifacts to use nf name instead of nsd name

Testing:

  • Testing single nf still behaves as expected with cnf to sns - ongoing

  • Test NSDV republish with same values

  • Test NSDV republish with different values

  • Test multi nf to sns with 2 CNFS:
    image

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jordlay jordlay requested a review from sunnycarter as a code owner May 3, 2024 16:02
@patrykkulik-microsoft
Copy link
Collaborator

Looks good to me

@jordlay jordlay merged commit eb492b0 into 2.0.0b2-release May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants